Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lens] split x-pack/test/functional/apps/lens/group3/config.ts into smaller groups #155860

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Apr 26, 2023

Summary

Re-grouping lens functional tests into 6 groups since 2 groups often cross the 35+ min runtime. Also, we have retry in place so pipeline might have +40 minutes run if any of test fails.

image

x-pack/test/functional/apps/lens/group1/config.ts 18m 42s
x-pack/test/functional/apps/lens/group2/config.ts 19m 26s
x-pack/test/functional/apps/lens/group3/config.ts 18m 26s
x-pack/test/functional/apps/lens/group4/config.ts 18m 40s
x-pack/test/functional/apps/lens/group5/config.ts 17m 55s
x-pack/test/functional/apps/lens/group6/config.ts 19m 24s

@dmlemeshko dmlemeshko force-pushed the ftr/split-lens-configs branch from 09dda3d to 9c386f9 Compare April 27, 2023 10:05
@dmlemeshko dmlemeshko added v8.8.0 v8.9.0 v8.7.2 release_note:skip Skip the PR/issue when compiling release notes labels Apr 27, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review April 27, 2023 15:47
@dmlemeshko dmlemeshko requested review from a team as code owners April 27, 2023 15:47
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmlemeshko dmlemeshko enabled auto-merge (squash) April 27, 2023 17:32
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / detection engine api security and spaces enabled - rule execution logic Threat match type rules terms and match should have the same alerts with pagination

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 483edea into elastic:main Apr 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
…maller groups (elastic#155860)

## Summary

Re-grouping lens functional tests into 6 groups since 2 groups often
cross the 35+ min runtime. Also, we have retry in place so pipeline
might have +40 minutes run if any of test fails.

<img width="1354" alt="image"
src="https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png">

x-pack/test/functional/apps/lens/group1/config.ts 18m 42s
x-pack/test/functional/apps/lens/group2/config.ts 19m 26s
x-pack/test/functional/apps/lens/group3/config.ts 18m 26s
x-pack/test/functional/apps/lens/group4/config.ts 18m 40s
x-pack/test/functional/apps/lens/group5/config.ts 17m 55s
x-pack/test/functional/apps/lens/group6/config.ts 19m 24s

---------

Co-authored-by: Jon <[email protected]>
(cherry picked from commit 483edea)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.7 Backport failed because of merge conflicts
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 155860

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 27, 2023
…into smaller groups (#155860) (#156075)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[lens] split x-pack/test/functional/apps/lens/group3/config.ts into
smaller groups (#155860)](#155860)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T18:14:41Z","message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.8.0","v8.7.2","v8.9.0"],"number":155860,"url":"https://github.com/elastic/kibana/pull/155860","mergeCommit":{"message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155860","number":155860,"mergeCommit":{"message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <[email protected]>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 1, 2023
…maller groups (elastic#155860)

## Summary

Re-grouping lens functional tests into 6 groups since 2 groups often
cross the 35+ min runtime. Also, we have retry in place so pipeline
might have +40 minutes run if any of test fails.

<img width="1354" alt="image"
src="https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png">

x-pack/test/functional/apps/lens/group1/config.ts 18m 42s
x-pack/test/functional/apps/lens/group2/config.ts 19m 26s
x-pack/test/functional/apps/lens/group3/config.ts 18m 26s
x-pack/test/functional/apps/lens/group4/config.ts 18m 40s
x-pack/test/functional/apps/lens/group5/config.ts 17m 55s
x-pack/test/functional/apps/lens/group6/config.ts 19m 24s

---------

Co-authored-by: Jon <[email protected]>
(cherry picked from commit 483edea)

# Conflicts:
#	x-pack/test/functional/apps/lens/group1/index.ts
#	x-pack/test/functional/apps/lens/group2/field_formatters.ts
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request May 2, 2023
…into smaller groups (#155860) (#156290)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[lens] split x-pack/test/functional/apps/lens/group3/config.ts into
smaller groups (#155860)](#155860)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T18:14:41Z","message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.8.0","v8.7.2","v8.9.0"],"number":155860,"url":"https://github.com/elastic/kibana/pull/155860","mergeCommit":{"message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/156075","number":156075,"state":"MERGED","mergeCommit":{"sha":"1a79030dbf17b08eb893e3bd7812e7b849a668bc","message":"[8.8]
[lens] split x-pack/test/functional/apps/lens/group3/config.ts into
smaller groups (#155860) (#156075)\n\n# Backport\n\nThis will backport
the following commits from `main` to `8.8`:\n- [[lens] split
x-pack/test/functional/apps/lens/group3/config.ts into\nsmaller groups
(#155860)](https://github.com/elastic/kibana/pull/155860)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Dzmitry\nLemechko\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2023-04-27T18:14:41Z\",\"message\":\"[lens]\nsplit
x-pack/test/functional/apps/lens/group3/config.ts into smaller\ngroups
(#155860)\\n\\n## Summary\\r\\n\\r\\n\\r\\nRe-grouping lens
functional\ntests into 6 groups since 2 groups often\\r\\ncross the 35+
min runtime.\nAlso, we have retry in place so pipeline\\r\\nmight have
+40 minutes run\nif any of test fails.\\r\\n\\r\\n<img
width=\\\"1354\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\\\">\\r\\n\\r\\nx-pack/test/functional/apps/lens/group1/config.ts\n18m
42s\\r\\nx-pack/test/functional/apps/lens/group2/config.ts
19m\n26s\\r\\nx-pack/test/functional/apps/lens/group3/config.ts
18m\n26s\\r\\nx-pack/test/functional/apps/lens/group4/config.ts
18m\n40s\\r\\nx-pack/test/functional/apps/lens/group5/config.ts
17m\n55s\\r\\nx-pack/test/functional/apps/lens/group6/config.ts
19m\n24s\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:
Jon\n<[email protected]>\",\"sha\":\"483edea966bfdd0d801ad28d5b681ca008a45ec8\",\"branchLabelMapping\":{\"^v8.9.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v8.8.0\",\"v8.7.2\",\"v8.9.0\"],\"number\":155860,\"url\":\"https://github.com/elastic/kibana/pull/155860\",\"mergeCommit\":{\"message\":\"[lens]\nsplit
x-pack/test/functional/apps/lens/group3/config.ts into smaller\ngroups
(#155860)\\n\\n## Summary\\r\\n\\r\\n\\r\\nRe-grouping lens
functional\ntests into 6 groups since 2 groups often\\r\\ncross the 35+
min runtime.\nAlso, we have retry in place so pipeline\\r\\nmight have
+40 minutes run\nif any of test fails.\\r\\n\\r\\n<img
width=\\\"1354\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\\\">\\r\\n\\r\\nx-pack/test/functional/apps/lens/group1/config.ts\n18m
42s\\r\\nx-pack/test/functional/apps/lens/group2/config.ts
19m\n26s\\r\\nx-pack/test/functional/apps/lens/group3/config.ts
18m\n26s\\r\\nx-pack/test/functional/apps/lens/group4/config.ts
18m\n40s\\r\\nx-pack/test/functional/apps/lens/group5/config.ts
17m\n55s\\r\\nx-pack/test/functional/apps/lens/group6/config.ts
19m\n24s\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:
Jon\n<[email protected]>\",\"sha\":\"483edea966bfdd0d801ad28d5b681ca008a45ec8\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.8\",\"8.7\"],\"targetPullRequestStates\":[{\"branch\":\"8.8\",\"label\":\"v8.8.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.7\",\"label\":\"v8.7.2\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v8.9.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/155860\",\"number\":155860,\"mergeCommit\":{\"message\":\"[lens]\nsplit
x-pack/test/functional/apps/lens/group3/config.ts into smaller\ngroups
(#155860)\\n\\n## Summary\\r\\n\\r\\n\\r\\nRe-grouping lens
functional\ntests into 6 groups since 2 groups often\\r\\ncross the 35+
min runtime.\nAlso, we have retry in place so pipeline\\r\\nmight have
+40 minutes run\nif any of test fails.\\r\\n\\r\\n<img
width=\\\"1354\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\\\">\\r\\n\\r\\nx-pack/test/functional/apps/lens/group1/config.ts\n18m
42s\\r\\nx-pack/test/functional/apps/lens/group2/config.ts
19m\n26s\\r\\nx-pack/test/functional/apps/lens/group3/config.ts
18m\n26s\\r\\nx-pack/test/functional/apps/lens/group4/config.ts
18m\n40s\\r\\nx-pack/test/functional/apps/lens/group5/config.ts
17m\n55s\\r\\nx-pack/test/functional/apps/lens/group6/config.ts
19m\n24s\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:
Jon\n<[email protected]>\",\"sha\":\"483edea966bfdd0d801ad28d5b681ca008a45ec8\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Dzmitry Lemechko
<[email protected]>"}},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155860","number":155860,"mergeCommit":{"message":"[lens]
split x-pack/test/functional/apps/lens/group3/config.ts into smaller
groups (#155860)\n\n## Summary\r\n\r\n\r\nRe-grouping lens functional
tests into 6 groups since 2 groups often\r\ncross the 35+ min runtime.
Also, we have retry in place so pipeline\r\nmight have +40 minutes run
if any of test fails.\r\n\r\n<img width=\"1354\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/234843379-aec47a81-22dc-4ecf-aee5-b1d489b3b31f.png\">\r\n\r\nx-pack/test/functional/apps/lens/group1/config.ts
18m 42s\r\nx-pack/test/functional/apps/lens/group2/config.ts 19m
26s\r\nx-pack/test/functional/apps/lens/group3/config.ts 18m
26s\r\nx-pack/test/functional/apps/lens/group4/config.ts 18m
40s\r\nx-pack/test/functional/apps/lens/group5/config.ts 17m
55s\r\nx-pack/test/functional/apps/lens/group6/config.ts 19m
24s\r\n\r\n---------\r\n\r\nCo-authored-by: Jon
<[email protected]>","sha":"483edea966bfdd0d801ad28d5b681ca008a45ec8"}}]}]
BACKPORT-->
@dmlemeshko dmlemeshko deleted the ftr/split-lens-configs branch November 21, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.7.1 v8.7.2 v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants